Skip to content

Conversation

Zakariathr22
Copy link
Contributor

@Zakariathr22 Zakariathr22 commented Aug 8, 2025

Description

When the app theme is set to Light or Dark (not “Use system setting”) and the app theme differs from the system theme, the app initially opens in the system theme and then switches to the chosen app theme.
Previously, the titlebar button colors were not updated during this theme change, resulting in low contrast.
This fix updates the button colors whenever the root grid theme changes and removes the old broken logic.

Motivation and Context

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Zakariathr22
Copy link
Contributor Author

@niels9001 @marcelwgn
could you please review this?

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Not sure why exactly we went with UISettings in the first place 😄

@marcelwgn marcelwgn enabled auto-merge (squash) August 12, 2025 08:17
@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn merged commit d05f9de into microsoft:main Aug 12, 2025
2 checks passed
@Zakariathr22 Zakariathr22 deleted the fix/titlebar-buttons-visibility branch August 12, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title bar wrong color Titlebar chrome buttons wrong color "invisible"
2 participants